[PATCH] Cygwin: remove most occurrences of __stdcall, WINAPI, and, __cdecl
Takashi Yano
takashi.yano@nifty.ne.jp
Mon Jun 6 23:21:40 GMT 2022
On Mon, 6 Jun 2022 12:24:15 -0400
Ken Brown wrote:
> On 6/5/2022 4:24 PM, Jon Turney wrote:
> > On 03/06/2022 15:00, Ken Brown wrote:
> >> remove most occurrences of __stdcall, WINAPI, and __cdecl
> >>
> >> These have no effect on x86_64. Retain only a few occurrences of
> >> __cdecl in files imported from other sources.
> >
> > While you are correct that it has no effect on x86_64, I'd incline towards
> > retaining WINAPI on Windows API functions, because it's part of the function
> > signature. But other people might have other opinions on that...
>
> I ended up retaining all occurrences of WINAPI. Those that don't directly occur
> in Windows API functions are mostly used for thread functions passed to
> CreateThread, and the latter expects a WINAPI function.
That sounds good to me.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
More information about the Cygwin-patches
mailing list