[PATCH] Cygwin: remove most occurrences of __stdcall, WINAPI, and, __cdecl

Ken Brown kbrown@cornell.edu
Tue Jun 7 18:00:18 GMT 2022


On 6/7/2022 12:49 PM, Takashi Yano wrote:
> _dll_crt0() is declared as
> extern void __stdcall _dll_crt0 ()
>    __declspec (dllimport) __attribute__ ((noreturn));
> in winsup/cygwin/lib/cygwin_crt0.c, however, this patch
> removes __stdcall from winsup.h and dcrt0.cc as follows.
[...]

> To be consistent these, shouldn't _dll_crt0() retain __stdcall?
> 
> Changing cygwin_crt0.c is a bit weird because it looks as if
> it might affect binary compatibility, even if it really doesn't.

Thanks for catching this.  It was actually an accident that I didn't remove 
__stdcall from cygwin_crt0.c, but I agree that it's better to retain it in the 
other two places.  I've fixed this.

Ken


More information about the Cygwin-patches mailing list