[PATCH rebase] Add support for Compact OS compression for Cygwin

Corinna Vinschen corinna-cygwin@cygwin.com
Thu Jul 14 14:54:11 GMT 2022


On Jul 14 16:41, Christian Franke wrote:
> Corinna Vinschen wrote:
> > On Jul 14 14:12, Christian Franke wrote:
> > 
> > > > > +#endif
> > > > This ifdef still makes sense, of course ...
> > > Could possibly also be enhanced to __MSYS__ and msys1.dll.
> > Not sure this makes sense.  Does their installer support CompactOS?
> 
> No, AFIAK. Then only (nonexistent?) users who run 'compact /c /exe:lzx ...'
> manually on their installation would benefit.
> 
> 
> > > 
> > > > ... and on first glance, the
> > > > remainder of the patch LGTM.
> > > Thanks. Attached is an alternative patch with most ifdefs removed.
> > LGTM.  I'm not going to push it, yet, because... do you still want to
> > add the aforementioned MSYS support?  If not, I'll just go ahead.
> 
> Please go ahead. I don't want to add platform specific code not actually
> tested on that platform.

Pushed.


Thanks,
Corinna


More information about the Cygwin-patches mailing list