[PATCH] Cygwin: pty: Fix a small bug in is_console_app().

Takashi Yano takashi.yano@nifty.ne.jp
Fri Aug 5 09:00:29 GMT 2022


- Previsouly, there was potential risk of buffer over run in
  is_console_app(). This patch fixes the issue.
---
 winsup/cygwin/spawn.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 4ec6a8789..d9d771651 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -207,7 +207,7 @@ is_console_app (WCHAR *filename)
   ReadFile (h, buf, sizeof (buf), &n, 0);
   CloseHandle (h);
   char *p = (char *) memmem (buf, n, "PE\0\0", 4);
-  if (p && p + id_offset <= buf + n)
+  if (p && p + id_offset < buf + n)
     return p[id_offset] == '\003'; /* 02: GUI, 03: console */
   else
     {
-- 
2.37.1



More information about the Cygwin-patches mailing list