[PATCH v3 0/3] use wincap in format_proc_cpuinfo for user_shstk

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Jun 19 08:55:59 GMT 2023


On Jun 16 15:26, Brian Inglis wrote:
> On 2023-06-16 13:51, Corinna Vinschen wrote:
> > Hi Brian,
> > 
> > On Jun 16 11:17, Brian Inglis wrote:
> 
> vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
> > > Fixes: 41fdb869f998 "fhandler/proc.cc(format_proc_cpuinfo): Add Linux 6.3 cpuinfo"
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
> > > In test for for AMD/Intel Control flow Enforcement Technology user mode
> > > shadow stack support replace Windows version tests with test of wincap
> > > member addition has_user_shstk with Windows version dependent value
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> > Is that actually the final version?  It's still missing the commit
> > message text explaining things and the "Fixes" line...
> Hi Corinna,
> 
> Is more required above?

No, it's fine, albeit "Fixes:" is supposed to be kind of like a footer,
just where the "Signed-off-by:" is, too.

But it's still only in the cover letter.  As I wrote, it needs to go
into the actual patch, otherwise all the nice info doesn't make it into
the git repo.


Thanks,
Corinna


More information about the Cygwin-patches mailing list