[PATCH v2] Cygwin: Fix type mismatch on sys/cpuset.h

Jon Turney jon.turney@dronecode.org.uk
Sat Jul 1 14:20:14 GMT 2023


On 14/03/2023 08:56, Mark Geisert wrote:
> Addresses https://cygwin.com/pipermail/cygwin/2023-March/253220.html
> 
> Take the opportunity to follow FreeBSD's and Linux's lead in recasting
> macro inline code as calls to static inline functions.  This allows the
> macros to be type-safe.  In addition, added a lower bound check to the
> functions that use a cpu number to avoid a potential buffer underrun on
> a bad argument.  h/t to Corinna for the advice on recasting.
> 
> Fixes: 362b98b49af5 ("Cygwin: Implement CPU_SET(3) macros")
> 

There's been a couple of reports that this leads to compilation failures 
when this header is included in -std=c89 mode.

Solutions are probably something like:

* Use __inline__ rather than inline
* Don't use initial declaration inside the for loop's init-statement

e.g. https://github.com/tinyproxy/tinyproxy/issues/499



More information about the Cygwin-patches mailing list