[PATCH v2] Cygwin: spawn: Fix segfalt when too many command line args are specified.

[Takashi Yano]

On Mon, 28 Aug 2023 12:57:19 +0200
Corinna Vinschen wrote:
> -      char *newargv[__argc + 1];
> -      char **nav = newargv;
> -      char **oav = __argv;
> -      while ((*nav++ = *oav++) != NULL)
> -	continue;
> +      char **newargv = (char **) malloc ((__argc + 1) * sizeof (char **));
> +      memcpy (newargv, __argv, (__argc + 1) * sizeof (char **));
>        /* Handle any signals which may have arrived */
>        sig_dispatch_pending (false);
>        _my_tls.call_signal_handler ();

Shouldn't this be sizeof (char *), not sizeof (char **)?

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>