[PATCH 3/4] Cygwin: CI: Make stress test terser

Jon Turney jon.turney@dronecode.org.uk
Sun Apr 20 19:27:23 GMT 2025


On 11/04/2025 17:08, Christian Franke wrote:
> Jon Turney wrote:
>> Don't echo the command being run
> 
> OK, but this breaks -n option which is occasionally useful, see below.

Yeah, that was dumb of me.

Posted a v2 of this series, with your updates as well.

>> Capture stress-ng output to file
>> Only show test output if it fails
>>
>> Capture all test output in an artifact
> 
> Are messages cygwin prints itself also captured? See below.
> 
> 
>> ---
>>   .github/workflows/cygwin.yml      | 10 ++++++++++
>>   winsup/testsuite/stress/cygstress | 13 ++++++++-----
>>   2 files changed, 18 insertions(+), 5 deletions(-)
>>
>> ...
>> -  echo '$' "${cmd[@]}"
>>     ! $dryrun || return 0
> 
> Possibly better:
> 
> if $dryrun; then
>    echo '$' "${cmd[@]}"
>    return 0
> fi
> 

This is, of course, the right way.

>>     (
>> @@ -520,7 +523,7 @@ stress()
>>     mkdir "$td"
>>     local rc=0
>> -  "${cmd[@]}" || rc=$?
>> +  "${cmd[@]}" >/dev/null || rc=$?
> 
> Redirect stderr to capture Cygwin's "panic" messages ?

Yeah, that seems better.

I was desperately trying make use of the '--log-file' option, but it 
doesn't seem to actually be useful here.



More information about the Cygwin-patches mailing list