[PATCH] Cygwin: kill(1): skip kill(2) call if '-f -s -' is used
Brian Inglis
Brian.Inglis@SystematicSW.ab.ca
Tue Apr 29 16:49:52 GMT 2025
On 2025-04-27 14:43, Christian Franke wrote:
> Brian Inglis wrote:
>> On 2025-04-27 12:22, Jon Turney wrote:
>>> On 15/04/2025 10:02, Christian Franke wrote:
>>>> Hi Takashi,
>>>>
>>>> Takashi Yano wrote:
>>>>> Hi Christian,
>>>>>
>>>>> On Fri, 11 Apr 2025 16:46:07 +0200
>>>>> Christian Franke wrote:
>>>>>> In rare cases, '/bin/kill -f PID' hangs because kill(2) is always tried
>>>>>> first. With this patch, this could be prevented with '/bin/kill -f -s -
>>>>>> PID'.
>>>
>>> As it currently stands, the -f flag to kill seems a bit misdesigned, i.e. if
>>> the signal isn't SIGKILL, -f shouldn't be accepted?
>>
>> Docs say -f uses Win32 interface so SIG... is irrelevant?
>>
>
> No, the current logic is:
> If -f is specified, Win32 TerminateProcess() is called after 'kill(pid, SIG...)'
> failed or if the process does not terminate within 200ms after kill() succeeded.
That's okay, but the suggestion was to require some specific SIG... for -f to
work: that changes the command spec: please don't do that; -f should be enough,
same as now.
I shouldn't have to know to specify some specific SIG..., default to (or
*force*) the required SIG... with -f!
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retrancher but when there is no more to cut
-- Antoine de Saint-Exupéry
More information about the Cygwin-patches
mailing list