[PATCH 3/3] Cygwin: testsuite: test passing directory fd to child

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Jun 30 09:51:54 GMT 2025


On Jun 27 12:13, Jeremy Drake via Cygwin-patches wrote:
> On Fri, 27 Jun 2025, Corinna Vinschen wrote:
> 
> > On Jun 26 13:34, Jeremy Drake via Cygwin-patches wrote:
> > > It doesn't make a whole lot of sense to redirect stdin/out/err to/from a
> > > directory handle, but test it anyway.
> >
> > I disagree.  There's nothing wrong if a program expects a directory
> > handle on a file descriptor if the task is, for instance, to perform
> > readdir on the incoming descriptor.
> >
> > Therefore, the code is ok, the commit message isn't.
> 
> Revised commit message
>     Cygwin: testsuite: test passing directory fd to child
> 
>     This is a legal (if non-obvious) thing to do, so test it.
> 
>     Signed-off-by: Jeremy Drake <cygwin@jdrake.com>
> 
> OK to push this series?

Yup, go ahead.

Thanks,
Corinna


More information about the Cygwin-patches mailing list