Cross Compiling - Annoying warnings

[Harold L Hunt II]

I sat down tonight to do a great amount of programming.  Instead, I have
been tracking annoying build warnings and fighting with Windows XP to try to
tell it, no, I really do want to search every single file, not just the ones
that Microsoft products are known to store text in... anyway...

The build warnings are below; they repeat for every Imakefile that is
processed during the build.

Okay, forget about HasMakefileSafeInclude... I want to fix
UseInstalledOnCrossCompile first.

Now, UseInstalledOnCrossCompile is a YES/NO define, it is not a flag that is
either defined or not defined.  Thus, the following lines that declare it
are stupid:

/*
 * X-specific things
 */
#if CrossCompiling
# if defined UseInstalled && !defined UseInstalledOnCrossCompile
#  define UseInstalledOnCrossCompile YES
# endif
#endif


So, if you aren't cross compiling, or if you are but you didn't specify
UseInstalled, then the flag will simply not be defined.  It won't be defined
to NO, like it should be.

I made the following changes that seemed to clear up this set of error
messages:

/*
 * X-specific things
 */
#if CrossCompiling
# if defined UseInstalled && !defined UseInstalledOnCrossCompile
#  define UseInstalledOnCrossCompile YES
# else
#  define UseInstalledOnCrossCompile NO
# endif
#else
# define UseInstalledOnCrossCompile NO
#endif


Any comments?


Harold



make[3]: Entering directory `/home/harold/x-devel/build/std/include'
In file included from ../../config/cf/cygwin.cf:358,
                 from ../../config/cf/Imake.tmpl:104,
                 from Imakefile.c:14:
../../config/cf/cygwin.rules:408: warning: `HasMakefileSafeInclude' is not
defined
In file included from ../../config/cf/Imake.tmpl:1999,
                 from Imakefile.c:14:
../../config/cf/X11.tmpl:1589: warning: `UseInstalledOnCrossCompile' is not
defined
In file included from ../../config/cf/Imake.tmpl:1999,
                 from Imakefile.c:14:
../../config/cf/X11.tmpl:3383: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3538: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3559: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3581: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3633: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3652: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3724: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3754: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3770: warning: `UseInstalledOnCrossCompile' is not
defined
../../config/cf/X11.tmpl:3812: warning: `UseInstalledOnCrossCompile' is not
defined
make[3]: Leaving directory `/home/harold/x-devel/build/std/include'