[patch] ambiguous else

Bernard Dautrevaux Dautrevaux@microprocess.com
Fri Oct 27 05:32:00 GMT 2000


> -----Original Message-----
> From: Jimen Ching [ mailto:jching@flex.com ]
> Sent: Friday, October 27, 2000 6:53 AM
> To: cygwin@sourceware.cygnus.com
> Subject: [patch] ambiguous else
> 
> 
> Hi all,
> 
> Can someone verify that the following patch is needed.
> 
> Also, in exceptions.cc, there is a comment in interrupt_setup 
> which says
> it is not multi-thread aware.  I am running into a strange 
> problem where I
> see an error about "couldn't send signal 14" and "wait for 
> sig_complete
> event failed, ..."  Are these related?  Can someone give me 
> some hints as
> to where to start looking if I want to know why these 
> messages are showing
> up?  Thanks.
> 
> --jc
> 
> --------------------------------------------------------------------
> diff -u -r1.51 sigproc.cc
> --- sigproc.cc	2000/10/23 20:50:36	1.51
> +++ sigproc.cc	2000/10/26 03:47:13
> @@ -1121,10 +1121,12 @@
>         * this thread should terminate.
>         */
>        if (rc == WAIT_TIMEOUT)
> +	{
>  	  if (!sig_loop_wait)
>  	    break;			// Exiting
>  	  else
>  	    continue;
> +	}
>  
>        if (rc == WAIT_FAILED)
>  	{
> 


These are not *needed*, but having them avoids anybody to wonder if the code
is doing this or that...

BTW, if you add the braces, you can even suppress the 'else' :-)

--------------------------------------------
Bernard Dautrevaux
Microprocess Ingenierie
97 bis, rue de Colombes
92400 COURBEVOIE
FRANCE
Tel:	+33 (0) 1 47 68 80 80
Fax:	+33 (0) 1 47 88 97 85
e-mail:	dautrevaux@microprocess.com
		b.dautrevaux@usa.net
-------------------------------------------- 

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe@sourceware.cygnus.com



More information about the Cygwin mailing list