console title

[Igor Pechtchanski]

On Thu, 14 Nov 2002, Christopher Faylor wrote:

> On Thu, Nov 14, 2002 at 11:46:23PM +0900, Hironori SAKAMOTO wrote:
> >Sorry, I made a mistake.
> >
> >> When a window title of cygwin console is displayed with escape
> >> sequence (\033]0;title\007), it can't be displayed if it includes
> >> non-ASCII characters (\200..\0377).
> >> Is the following patch acceptable ?
> >
> >This is the correct patch.
>
> This can't be correct.  It's not possible for a character to be greater
> than 0377 anyway so your change is meaningless.
>
> I'll just remove the >= '\177' entirely.  Somebody (me) obviously wasn't
> thinking globally when they wrote that.  This will be in a snapshot soon.
>
> cgf

Are characters signed, or unsigned?  If they are signed, this test may not
work (i.e., all characters above 0177 will be caught by the *src < ' '
test).
	Igor

> >--- fhandler_console.cc.orig   Thu Nov 14 14:51:30 2002
> >+++ fhandler_console.cc        Thu Nov 14 15:01:54 2002
> >@@ -1530,7 +1530,7 @@
> >       case gettitle:
> >         {
> >           int n = strlen (dev_state->my_title_buf);
> >-          if (*src < ' ' || *src >= '\177')
> >+          if (*src < ' ' || *src >= 0377)
> >             {
> >               if (*src == '\007' && dev_state->state_ == gettitle)
> >                 {

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Water molecules expand as they grow warmer" (C) Popular Science, Oct'02, p.51


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/