1.3.22: gdbm-1.8.3 build error

[Doru Carastan]

Hello,

I have tried to rebuild gdbm-1.8.3 and got a make install error. 
Makefile installs some files with explicit ownership. Unfortunately the 
group and owner variables are not double quoted and the commands fail if 
the variables contain spaces.

gdbm-1.8.3/Makefile:138

install: libgdbm.la gdbm.h gdbm.info
    $(srcdir)/mkinstalldirs $(INSTALL_ROOT)$(libdir) \
        $(INSTALL_ROOT)$(includedir) $(INSTALL_ROOT)$(man3dir) \
        $(INSTALL_ROOT)$(infodir)
    $(LIBTOOL) --mode=install $(INSTALL) -c libgdbm.la \
        $(INSTALL_ROOT)$(libdir)/libgdbm.la
    $(INSTALL_DATA) -o $(BINOWN) -g $(BINGRP) gdbm.h \
        $(INSTALL_ROOT)$(includedir)/gdbm.h
    $(INSTALL_DATA) -o $(BINOWN) -g $(BINGRP) $(srcdir)/gdbm.3 \
        $(INSTALL_ROOT)$(man3dir)/gdbm.3
    $(INSTALL_DATA) -o $(BINOWN) -g $(BINGRP) $(srcdir)/gdbm.info \
        $(INSTALL_ROOT)$(infodir)/gdbm.info

And my group file has group names with spaces. I have recently used 
'mkgroup -dl > /etc/group' to re-create my /etc/group files and got the 
following:

SYSTEM:S-1-5-18:18:
None:S-1-5-21-720897496-2436313513-572454927-513:513:
Domain Admins:S-1-5-21-1286613485-1828479051-310601177-512:10512:
Domain Guests:S-1-5-21-1286613485-1828479051-310601177-514:10514:
Domain Users:S-1-5-21-1286613485-1828479051-310601177-513:10513:
Administrators:S-1-5-32-544:544:
Backup Operators:S-1-5-32-551:551:
Guests:S-1-5-32-546:546:
Network Configuration Operators:S-1-5-32-556:556:
Power Users:S-1-5-32-547:547:
Remote Desktop Users:S-1-5-32-555:555:
Replicator:S-1-5-32-552:552:
Users:S-1-5-32-545:545:
Debugger Users:S-1-5-21-720897496-2436313513-572454927-1005:1005:
HelpServicesGroup:S-1-5-21-720897496-2436313513-572454927-1001:1001:
VS Developers:S-1-5-21-720897496-2436313513-572454927-1006:1006:

I got around by removing the spaces present in the group names, but I 
would like to ask (Corinna?) what is the right way to fix this problem:

a. Sanitize /etc/groups by removing any spaces present in the group names.
b. Modify the Makefile and add the necessary double quoting.

Is there a special reason why mkgroup doesn't remove the spaces present 
in the Windows group names or substitute them let's say with _'s?

Thank you,

----------------------------------------------------------------------
Doru Carastan                                         Windows Host 
Contractor
(408)-992-4497                                      MontaVista Software

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cygcheck.txt
URL: <http://cygwin.com/pipermail/cygwin/attachments/20031025/1a25ffdd/attachment.txt>
-------------- next part --------------
--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/