support dirent.d_type

[Igor Pechtchanski]

On Fri, 22 Apr 2005, Christopher Faylor wrote:

> On Fri, Apr 22, 2005 at 11:37:59AM -0400, Igor Pechtchanski wrote:
> >On Fri, 22 Apr 2005, lode leroy wrote:
> >>I would like to see support for dirent.d_type added to cygwin.
> >>
> >>fhandler_disk_file::readdir()
> >>{
> >>...
> >> if (buf.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
> >>   dir->__d_dirent->d_type = DT_DIR;
> >> } else {
> >>   dir->__d_dirent->d_type = DT_REG;
> >> }
> >>...
> >>}
> >
> >So why not make it a patch, test it, and send it to the appropriate list
> >with a ChangeLog entry?  For something this small you don't even need a
> >copyright assignment.  See <http://cygwin.com/contrib.html>.
>
> Actually, thanks but I don't think we want to go down this path.
>
> Properly implementing this field would introduce the same problems as
> properly implementing d_ino.  Doing this would mean adding too much
> overhead to readdir.

I didn't say that the patch would be accepted.  IMO, having an actual
patch in hand would make it easier to review the suggestion, and, if
necessary, to articulate the reasons for rejecting it.  Also, if the OP
had tried the actual patch, he would have realized that, with all the
missing features added, the patch would not be quite as trivial as he
imagined.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"The Sun will pass between the Earth and the Moon tonight for a total
Lunar eclipse..." -- WCBS Radio Newsbrief, Oct 27 2004, 12:01 pm EDT

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/