w32api-headers-3.0b_svn5431-1: _WIN32 no longer set on Cygwin

Christian Franke Christian.Franke@t-online.de
Sat Oct 20 17:32:00 GMT 2012


Kai Tietz wrote:
> 2012/10/20 JonY wrote:
>> On 10/20/2012 21:12, Christian Franke wrote:
>>> Just for Info:
>>>
>>> The new /usr/include/w32api/windef.h does no longer define _WIN32.
>>>
>>> This may require compile fixes for some sources which check only for
>>> _WIN32 and not for __CYGWIN__ after windows.h is included.
>>>
>>> Christian
>> I can't imagine why you'd include windows.h and then check for _WIN32
>> after the fact, but I still think mixing win32 calls and Cygwin calls is
>> a bad idea, except for a few special cases.
>>
>> Anyway, I'll leave it to Kai to decide if it should be done, as I'm not
>> sure if this request is proper.
> That we don't define _WIN32 - actual we do internally but don't show
> it to includer - is done by intention.  Actual Corinna and I decided
> that this behavior is for cygwin the desired.

For the long term, it was IMO a good decision to change (fix) the old 
behavior.

For now, some (trivial) fixes to existing code may be required. I built 
the smartmontools-6.0-1 Cygwin package a few hours before the new 
headers were uploaded. Build from source package does no longer work 
with new headers (unfortunately the foreign CSMI include file requires 
_WIN32).

Christian


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple



More information about the Cygwin mailing list