Difference in 32/64-bit curl.

[Christian Franke]

Christian Franke wrote:
> Corinna Vinschen wrote:
>> On Apr 23 23:56, Christian Franke wrote:
>>> Fredrik Rothamel wrote:
>>>> I just noticed that in 64-bit cygwin curl always include the
>>>> http-headers in the response.
>>>> (Old behaviour is to only include headers when -i option is
>>> specified) >
>>>> Is this an intentional change?
>>> Unlikely. In this case it should be possible to revert the default
>>> -i (--include) with --no-include.
>>>
>> What about a type issue?  int vs. long?
>>
> Yes, option is possibly set as int (bool) but retrieved as long:
>
> src/tool_cfgable.h:89:
>   bool include_headers;     /* ... */
>
> src/tool_operate.c:886:
>   my_setopt(curl, CURLOPT_HEADER, config->include_headers);
>
> lib/url.c:704:
> case CURLOPT_HEADER:
> ...
>   data->set.include_header = (0 != va_arg(param, long))?TRUE:FALSE;
>
>

The attached patch would actually fix the issue. Likely not the correct 
way to do this as va_arg(param, long) is also used for the other integer 
options.

Is this possibly an upstream bug which is hidden on Linux et al. due to 
a different x64 ABI (which requires register parameter zero extension) ?

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: curl.patch
Type: text/x-patch
Size: 473 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin/attachments/20130425/a155e831/attachment.bin>
-------------- next part --------------
--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple