MSYS mode (continue)

Alexey Pavlov alexpux@gmail.com
Thu Jul 4 09:07:00 GMT 2013


2013/7/4 Corinna Vinschen:
> Hi Alexey,
>
> On Jul  4 06:33, Alexey Pavlov wrote:
>> My opinion is to extend Cygwin parser to read msys-like mounts. It's
>> very simple:
>>
>> --- mount.cc 2013-04-24 20:29:29.000000000 +0400
>> +++ Cygwin/winsup/cygwin/mount.cc 2013-06-13 09:35:01.479492100 +0400
>> @@ -1125,8 +1118,17 @@
>>    if (!*c)
>>      return true;
>>    cend = find_ws (c);
>> -  *cend = '\0';
>>    posix_path = conv_fstab_spaces (c);
>> +  if (!*cend)
>> +   {
>> +     unsigned mount_flags = MOUNT_SYSTEM | MOUNT_BINARY |
>> MOUNT_NOPOSIX | MOUNT_NOACL;
>> +
>> +     int res = mount_table->add_item (native_path, posix_path, mount_flags);
>> +     if (res && get_errno () == EMFILE)
>> +       return false;
>> +     return true;
>> +   }
>> +  *cend = '\0';
>>    /* Third field: FS type. */
>>    c = skip_ws (cend + 1);
>>    if (!*c)
>
> This patch is trivial enough to go in (barring discussion) without
> copyright assignment.   Still, the CA is necessary for more complex
> patches.
>
Good.

> Would you mind to send a CA (http://cygwin.com/assign.txt) per snail
> mail to the address given in the form?
>
I will do it in a week I think.

> Apart from that, please provide a ChangeLog entry.  Please read
> http://cygwin.com/contrib.html, especially the last section called
> "When you have finalized your changes".
>
Ok.
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Maintainer                 cygwin AT cygwin DOT com
> Red Hat
>
> --
> Problem reports:       http://cygwin.com/problems.html
> FAQ:                   http://cygwin.com/faq/
> Documentation:         http://cygwin.com/docs.html
> Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
>

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple



More information about the Cygwin mailing list