Problem with new acl code and cdrtools

[Ismail Donmez]

Hi,

On Tue, Feb 9, 2016 at 6:14 AM, Warren Young <wyml@etr-usa.com> wrote:
> On Feb 8, 2016, at 9:59 AM, Ismail Donmez <ismail@i10z.com> wrote:
>>
>> On Mon, Feb 8, 2016 at 6:29 PM, Peter Rosin <peda@lysator.liu.se> wrote:
>>> On 2016-02-08 14:31, Ismail Donmez wrote:
>>>> This is a generic code so I don't want to add a cygwin specific
>>>> dependency there. Is there a preprocessor definition for cygwin
>>>> version? I could use that to disable HAVE_SUN_ACL for cygwin 2.5+
>>>
>>> Pardon me for butting in, but isn't adding a Cygwin version check
>>> about as non-generic as it gets?
>>>
>>> Wouldn't something like this work:
>>>
>>> .../configure ac_cv_func_aclfromtext=no
>>
>> Thats a hack :)
>
> I don’t know if that smiley means you’re joking or if you’re just trying to soften a negative judgement, but Peter’s proposal is as far from a hack as it gets.

What Peter suggests is telling autoconf to assume aclfromtext() does
not exist on the system which is a hack and I already have a hack I
could use.

> He is proposing that you write an autoconf test that determines if the platform has this new ACL behavior.  Then in your C code:
>
>    #include <config.h>
>    #if HAVE_FUNC_ACLFROMTEXT
>    #  include <cygwin/acl.h>
>    #endif

I could check for __cygwin__ instead of that which would do the same thing.

Anyhow the discussion diverged a lot, and for now I'll be using my
simple hack of disabling HAVE_SUN_ACL manually.

ismail

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple