iswcntrl() regression

Thomas Wolff towo@towo.net
Sat Jan 12 11:39:00 GMT 2019


Am 11.01.2019 um 10:16 schrieb Corinna Vinschen:
> On Jan 11 02:07, Thomas Wolff wrote:
>> Am 06.01.2019 um 23:39 schrieb Thomas Wolff:
>>> Am 06.01.2019 um 21:21 schrieb Corinna Vinschen:
>>>> On Dec 19 21:57, Bruno Haible wrote:
>>>>> Hello Thomas,
>>>>>
>>>>> Oops 1: I forgot to add the reference to POSIX:
>>>>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswcntrl.html
>>>>>
>>>>> Oops 2:
>>>>> The relevant expression is iswcntrl (WEOF), not iswcntrl (EOF).
>>>>> [...]
>>>> Thomas, any input?  Are you going to provide patches?
>>> Well, yes, now I'm assuming that this is the only WEOF special case and
>>> I'll look after it this week.
>>> Thomas
>> The fix should be as attached.
>> However, I don't seem to be able to produce a git format patch; when I `git
>> format-patch -1` (after `git pull` and modifying only the affected file) it
>> produces a patch file
>>
>> Subject: [PATCH] Cygwin: try_to_bin: don't check recycler filename all the
>> time
>> ...
>> Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
>> ---
>>   winsup/cygwin/syscalls.cc | 71 +++++++++++++++++++++------------------
>> ...
>>
>> which is weird.
> No, it's not.  Only commited patches are printed by `git format-patch',
> so, after `git pull' you have to *commit* your patches, write a nice
> description (with a blank line after the first line to separate the
> commit message into synopsis and body).  *Then* call `git format-patch -1'.
Blush; forgot about the workflow...
> Apart from that, please send your patch to the newlib mailing list.
Done.
Also sent a Unicode 11.0 update patch.
Thomas

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple



More information about the Cygwin mailing list