Incorrect behavior in TIOCINQ ioctl

[Åke Rehnman]

Hi,

I recently ran in to some troubles with the TIOCINQ ioctl. I am 
wondering if the cygwin implementation is correct... It seems if there 
were any existing framing overrun errors etc etc  before calling the 
TIOCINQ ioctl it is returning an error (EINVAL). Reading through linux 
implmentation of TIOCINQ does simply return number of pending chars 
without any clearing or checking for errors.

I suggest the whole if (ev & CE_FRAMEÂ  ...... ) is removed.

Excerpt from fhandler_serial.cc:

/* ioctl: */
int
fhandler_serial::ioctl (unsigned int cmd, void *buf)
{
.
.
 Â  if (!ClearCommError (get_handle (), &ev, &st))
 Â Â Â  {
 Â Â Â Â Â  __seterrno ();
 Â Â Â Â Â  res = -1;
 Â Â Â  }
.
.
.
 Â Â Â Â  case TIOCINQ:
 Â Â Â Â Â Â  if (ev & CE_FRAME || ev & CE_IOE || ev & CE_OVERRUN || ev & 
CE_RXOVER
 Â Â Â  Â Â  || ev & CE_RXPARITY)
 Â Â Â  Â {
 Â Â Â  Â Â  set_errno (EINVAL);Â Â Â  /* FIXME: Use correct errno */
 Â Â Â  Â Â  res = -1;
 Â Â Â  Â }
 Â Â Â Â  else
 Â  Â  Â  Â  ipbuf = st.cbInQue;
 Â Â Â Â  break;



--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple