Update request for rdiff-backup

[Cygwin]

> On 4/28/2020 11:43 PM,qrasmfu8f4@snkmail.com  <mailto:qrasmfu8f4@snkmail.com>  wrote:
> >/Cygwin currently contains version 1.2.8-6 of rdiff-backup. Based on 
> what I see at https://github.com/rdiff-backup/rdiff-backup/releases, 
> 1.2.8 is about 11 years old (you'll have to click "Show 7 other tags), 
> although it appears there were no releases for 10 years. There has, 
> however been some recent activity, and version 2.0,0 was released on 
> March 15th. Would it be possible to update cygwin to version 2.0.0 of 
> rdiff-update? /
> I have updated rdiff-backup to 2.0.0 and pushed the new package as a
> TEST release (since I don't use rdiff-backup anymore). Please test and
> report back if you find any problems. I'll plan to promote it to
> official status in a couple weeks unless you have problems.
>
>
> -- 
> David Rothenberger  ----daveroth@acm.org  <mailto:daveroth@acm.org>

Thanks for doing the update David.  I upgraded to rdiff-backup-2.0.0-1 
and found that running "rdiff-backup --help" produced

    Exception 'name 'local' is not defined' raised of class '<class
    'NameError'>':
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 391, in error_check_Main
         Main(arglist)
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 406, in Main
         local.setlocale(locale.LC_ALL, '')

    Traceback (most recent call last):
       File "/usr/bin/rdiff-backup", line 32, in <module>
         rdiff_backup.Main.error_check_Main(sys.argv[1:])
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 391, in error_check_Main
         Main(arglist)
       File "/usr/lib/python3.6/site-packages/rdiff_backup/Main.py",
    line 406, in Main
         local.setlocale(locale.LC_ALL, '')
    NameError: name 'local' is not defined

Attempting a real use of rdiff-backup gave a similar result. Looking at 
the rdiff-backup source in github as well as the python 3.6 docs, it 
looks you added line 406 in Main.py and I think it has a typo.  "local" 
should be "locale".

BTW, I was playing around with rdiff-backup 1.2.8-6 a couple days ago, 
and while it seemed to work fine when the destination was on a local 
drive, I couldn't figure out how to get it to work when the destination 
is a network share If I specify the destination as 
'//192.168.1.250/finance-backup/finance.rdiff-backup' I get:

      Fatal Error: Unable to create directory
    /192.168.1.250/finance-backup/finance.rdiff-backup

but "mkdir //192.168.1.250/finance-backup/finance.rdiff-backup" works fine.

If I specify the destination as 
'\\192.168.1.250\finance-backup\finance.rdiff-backup' I get:

    Exception '' raised of class '<type 'exceptions.AssertionError'>':
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 305, in error_check_Main
         try: Main(arglist)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 326, in Main
         take_action(rps)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 281, in take_action
         elif action == "backup": Backup(rps[0], rps[1])
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 336, in Backup
         rpout.conn.fs_abilities.backup_set_globals(rpin, force)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 922, in backup_set_globals
         dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 167, in init_readwrite
         self.set_symlink_perms(subdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 547, in set_symlink_perms
         sym_dest.symlink("symlinked_file1")
       File "/usr/lib/python2.7/site-packages/rdiff_backup/rpath.py",
    line 1004, in symlink
         assert self.issym()

    Traceback (most recent call last):
       File "/usr/bin/rdiff-backup", line 30, in <module>
         rdiff_backup.Main.error_check_Main(sys.argv[1:])
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 305, in error_check_Main
         try: Main(arglist)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 326, in Main
         take_action(rps)
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 281, in take_action
         elif action == "backup": Backup(rps[0], rps[1])
       File "/usr/lib/python2.7/site-packages/rdiff_backup/Main.py",
    line 336, in Backup
         rpout.conn.fs_abilities.backup_set_globals(rpin, force)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 922, in backup_set_globals
         dest_fsa = FSAbilities('destination').init_readwrite(Globals.rbdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 167, in init_readwrite
         self.set_symlink_perms(subdir)
       File
    "/usr/lib/python2.7/site-packages/rdiff_backup/fs_abilities.py",
    line 547, in set_symlink_perms
         sym_dest.symlink("symlinked_file1")
       File "/usr/lib/python2.7/site-packages/rdiff_backup/rpath.py",
    line 1004, in symlink
         assert self.issym()
    AssertionError

Would you have any suggestions about how to put the output on a network 
share?

Also, if you don't use rdiff-backup any more, have you found something 
you like better?