mmap failure [was: cygrunsrv + sshd + rsync = 20 times too slow -- throttled?]

Lavrentiev, Anton (NIH/NLM/NCBI) [C] lavr@ncbi.nlm.nih.gov
Tue Sep 7 21:52:01 GMT 2021


> >
> > With undocumented structure member initialization an issue, maybe better to
> > future proof using e.g.
> >
> >      MEM_EXTENDED_PARAMETER mmap_ext = { 0 }; // or memset or bzero
> 
> I don't see what this would accomplish.  We're already initializing every member
> after Corinna's last patch.
> 

Well, if one day MS decides to use some of the Reserved field by splinting off a new
named field out of that bulk of bits, the code will be in trouble again...
While with memset, bzero or C-style initializer, everything is guaranteed to be zapped with 0.

Anton Lavrentiev
Contractor NIH/NLM/NCBI



More information about the Cygwin mailing list