mintty crashes on Windows 7

[Orgad Shaneh]

On Wed, May 4, 2022 at 2:16 PM Takashi Yano <takashi.yano@nifty.ne.jp> wrote:
>
> > Reduced the revert to this:
> > @@ -979,16 +979,10 @@ fhandler_pty_slave::open (int flags, mode_t)
> >         code does not work as expected because it calls Win32
> >         API directly rather than cygwin read()/write(). Due to
> >         this behaviour, protection based on attach_mutex does
> >         not take effect. */
> >      get_ttyp ()->need_invisible_console = true;
> > -  else if (_major (myself->ctty) != DEV_CONS_MAJOR
> > -    && (!get_ttyp ()->invisible_console_pid
> > -        || !pinfo (get_ttyp ()->invisible_console_pid)))
> > -    /* Create a new invisible console for each pty to isolate
> > -       CTRL_C_EVENTs between ptys. */
> > -    get_ttyp ()->need_invisible_console = true;
> >    else
> >      {
> >        acquire_attach_mutex (mutex_timeout);
> >        fhandler_console::need_invisible ();
> >        release_attach_mutex ();
>
> A few things about this.
>
> 1) bash exits with exit code 127 for 'mintty bash'
> 2) 'mintty bash' does not work, but 'mintty ash' and 'mintty tcsh' work.

Right. mintty dash also works.

Notice that I did *not* set enable_pcon (not supported on Win7 anyway).

- Orgad