This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: a review and questions on avr_scan_prologue()

From: Petr HluzÃn <petr dot hluzin at gmail dot com>
To: Tristan Gingold <gingold at adacore dot com>, Eric Weddington <Eric dot Weddington at atmel dot com>
Cc: gdb at sourceware dot org
Date: Sun, 21 Feb 2010 00:20:29 +0100
Subject: Re: a review and questions on avr_scan_prologue()
References: <6a6f635a1002131556sc428adfu6033489930eca7b6@mail.gmail.com> <919F238C-4ED8-4507-8510-E5479E94B32D@adacore.com>

Hi

On 17 February 2010 10:02, Tristan Gingold <gingold@adacore.com> wrote:
>> Â Â Âelse if (insn == 0x920f) Â/* push r0 */
>> Â Â Â Â{
>> Â Â Â Â Âinfo->size += 1;
>> Â Â Â Â Âvpc += 2;
>> Â Â Â Â}
>>
>> The condition is never true because of the preceding "Scan pushes
>> (saved registers)" loop's exit condition.
>
> I don't think so. ÂYou can have:
> Ârcall .+0
> Âpush r0

You are right. (I have not realized that such case would be useful for
something.)

(Since you already committed the changes I am not filling the bug reports
Eric Weddington requested.)

-- 
Petr Hluzin

References:
- a review and questions on avr_scan_prologue()
  - From: Petr HluzÃn
- Re: a review and questions on avr_scan_prologue()
  - From: Tristan Gingold

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]