[SETUP] - Roberts code refactor suggestion and help needed

Brian Keener bkeener@thesoftwaresource.com
Wed Apr 30 20:14:00 GMT 2003


To all,

When we did the previous rollout of setup I had some changes included for the 
new views we added and in message

http://cygwin.com/ml/cygwin-apps/2003-03/msg00085.html

when Robert told Max to go ahead and commit the changes Robert also suggested 
that there was way too much duplicate code in one section and we should 
refactor the code and he gave a small sample of some new code.  

I really want to work on this but since I am sort of teaching myself C++ I am a 
bit confused. I have been studying up on Predicates and looking at the source 
code and understand the various predicates needed should be a member an already 
defined object or class (say for example PickView).  Beyond that what would 
really help me now and how I have managed some of my other changes is if there 
is someplace within the Setup sources where something similar to this was 
already done that I can study and use as a guide.  Any Ideas anyone?

bk




More information about the Cygwin-apps mailing list