[ITA] _autorebase

[Ken Brown]

On 12/14/2014 3:56 AM, Achim Gratz wrote:
>
> Packages rebuilt with cygport including the changes discussed with Ken
> and pre-compiled setup.exe files added.
>
> --8<---------------cut here---------------start------------->8---
> cygwin=http://cygwin.stromeko.net/
> wget $cygwin/noarch/release/_autorebase/_autorebase-001000-1-src.tar.xz
> wget $cygwin/noarch/release/_autorebase/_autorebase-001000-1.tar.xz
> wget $cygwin/noarch/release/_autorebase/setup.hint
> wget $cygwin/x86/setup-x86.exe
> wget $cygwin/x86_64/setup-x86_64.exe
> --8<---------------cut here---------------end--------------->8---

I just noticed a couple of things about the base address.  First, you have a 
typo in line 4 of rebaselst (missing 'd').  Second, you use a default base 
address of 0x70000000 on both arches, but rebaseall uses 0x400000000 on x86_64.

I also just noticed that rebaseall passes the --no-dynamicbase option to rebase. 
  Maybe you should do the same, and then you could forget about the --noaslr 
option and unconditionally remove the call to peflags from rebase_do.

Sorry about the constant nitpicking, but I only just thought of comparing your 
script to rebaseall.

I'm going to test this now, but I've already tested earlier versions, so I don't 
expect to find any problems.

You've done a great service by improving setup.exe and _autorebase, and I 
personally think you deserve a gold star for this work.

Ken