[PATCH cygport 2/2] Don't use llvm-objdump

Jon Turney jon.turney@dronecode.org.uk
Tue Feb 1 17:25:19 GMT 2022


This partially reverts commit e06359bca705624b9712fd16f4ec9945935fd608
This partially reverts commit 6f788165848084d2fb1597689b31faba7d4c483e

The polynomially bad runtime of 'objdump' (which made 'llvm-objdump' the
only practically usable tool on larger binaries) has been fixed since
[1].  Meanwhile, 'llvm-objdump' now appears to have bugs which interfere
with the correct operation of cygport.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=18025#c16
---
 lib/pkg_info.cygpart     | 8 --------
 lib/src_postinst.cygpart | 7 +------
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/lib/pkg_info.cygpart b/lib/pkg_info.cygpart
index 4b18993..08ddd69 100644
--- a/lib/pkg_info.cygpart
+++ b/lib/pkg_info.cygpart
@@ -95,14 +95,6 @@ __list_deps() {
 		dlltool="${CTARGET}-dlltool"
 	fi
 
-	case ${CHOST} in
-	i?86-*|x86_64-*)
-		if check_prog llvm-objdump
-		then
-			objdump="llvm-objdump"
-		fi ;;
-	esac
-
 	pushd ${D}
 
 #****v* Information/DEPS_PATH
diff --git a/lib/src_postinst.cygpart b/lib/src_postinst.cygpart
index e29b2cb..4b51325 100644
--- a/lib/src_postinst.cygpart
+++ b/lib/src_postinst.cygpart
@@ -951,12 +951,7 @@ __prepstrip() {
 			continue
 		fi
 
-		if check_prog llvm-objdump && llvm-size "${exe}" &>/dev/null
-		then
-			objdump="llvm-objdump"
-		else
-			objdump=${objcopy/copy/dump}
-		fi
+		objdump=${objcopy/copy/dump}
 
 		# Static libraries should not be fully stripped, but we can
 		# still provide split debuginfo if desired
-- 
2.34.1



More information about the Cygwin-apps mailing list