[ITA] astyle

[Brian Inglis]

On 2025-02-02 10:29, Michael Cook via Cygwin-apps wrote:
> Let's see if I understand correctly...
> 
> In cygwin-packages I have this:
> 
> $ git remote -v
> origin https://cygwin.com/git/cygwin-packages/astyle/ (fetch)
> origin https://cygwin.com/git/cygwin-packages/astyle/ (push)
> $ git status
> On branch master
> Your branch is up to date with 'origin/master'.
> 
> 
> Untracked files:
>    (use "git add <file>..." to include in what will be committed)
> .gitignore
> astyle.cygport
> 
> 
> nothing added to commit but untracked files present (use "git add" to track)
> $
> 
> 
> I think I should commit these files and push them directly to the upstream
> master.
> 
> Should I `git rm astyle-2.06*`? Or just leave them. Or does it not matter.

 > Then I can do
 > cygport astyle.cygport all

I would run cygport ... all *check* first; then if all looks okay,
push to repo to run CI build and check, and if all looks okay,
clean up the repo,
then upload, and after you get the calm emailed upload report,
then announce.

> cygport astyle.cygport up
> 
> 
> and using lftp I should see files have appeared in x86_64/release/astyle/
> 
> Then I create the !ready file:
> 
> lftp cygwin.com:/x86_64/release> put /dev/null -o !ready
> 
> Then some time later I'll get an email saying that my upload was detected
> by "calm" and passed whatever checks calm does.
> (The https://cygwin.com/package-upload.html page talks about "calm" without
> explaining what it is. I infer it's some kind of CI bot.)
> 
> Next, this page
> https://cygwin.com/packaging-contributors-guide.html#updating says to
> run "cygport
> announce" to start composing an announcement email.
> The page doesn't say explicitly where to send the email.
> I'm guessing I just send it to cygwin-announce@cygwin.com
> 
> Then I'm done.
> Is that right?
> 
> Michael
> 
> On Thu, Jan 30, 2025 at 11:05 AM Marco Atzeri via Cygwin-apps <
> cygwin-apps@cygwin.com> wrote:
> 
>> On 30/01/2025 13:36, Michael Cook via Cygwin-apps wrote:
>>> The astyle version used in the Cygwin package is 2.06 from 2016.
>>>
>>> I have a working package using the latest astyle release 3.6.6.
>>> * `cygport download all-test check` succeeds
>>> * running the resulting astyle.exe in an existing source code repo worked
>>> as expected
>>>
>>> What's the next step?
>>>
>>> This would be my first contribution to Cygwin.
>>>
>>> Michael
>>
>> Hi Michael,
>>
>> Can you provide the cygport file as attachment ?
>> We can review it and comment if needed.
>>
>> After GTG (Good to Go) approval from other packagers
>> and you providing  your SSH Key
>>
>>     https://cygwin.com/packaging/key.html#sshkey
>>
>> you can follow the upload procedure
>>
>>     https://cygwin.com/package-upload.html
>>
>> There is also a build server that from the git package repository,
>> can build, package , test and upload with you.
>>
>> https://cygwin.com/packaging/build.html
>> https://cygwin.com/cgi-bin2/jobs.cgi
>>
>> It is very convenient for any future release, as the workload
>> is not on your machine and the build is sanitized as enviroment.
>>
>> Regards
>> Marco
>>
>>


-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retrancher  but when there is no more to cut
                                 -- Antoine de Saint-Exupéry