printfs in cygserver?

Christopher Faylor cgf@redhat.com
Fri Jul 5 10:08:00 GMT 2002


On Fri, Jul 05, 2002 at 11:48:24AM +0100, Conrad Scott wrote:
>"Christopher Faylor" <cgf@redhat.com> write:
>> There seems to be a lot of of "printfs" in cygserver code that
>is
>> apparently linked into cygwin.  I specifically noticed it it
>> cygserver_transport_pipes.cc and cygserver_transport_sockets.cc.
>> Is this being corrected?  We don't use raw printf in cygwin
>code.
>
>I've fixed this on the cygwin_daemon branch.  In case it's
>something you'd like fixed immediately, attached is a (slightly
>updated) copy of a patch I previously submitted to Rob that, among
>other things, changes the cygserver code to use the xxx_printf
>calls from "strace.h".  I'd be happy for this to go into HEAD;
>it's not a functionality patch, more of a brisk clean-up and
>rub-down patch :-)

You're the maintainer now so the decision of what goes into head
is pretty much yours.  If you think it should be checked in, go
for it.

cgf



More information about the Cygwin-patches mailing list