More changes about open on Win95 directories.
Pierre A. Humblet
Wed Sep 18 21:15:00 GMT 2002
At 11:34 PM 9/18/2002 -0400, Christopher Faylor wrote:
>> if (fl->l_len < 0)
>> win32_start -= fl->l_len;
>> win32_len = -fl->l_len;
>I've looked at that code a few times and wondered about that. It seems
>backwards but maybe someone else has more insight.
Like, if start = 20 and len = -10, the code above locks 30 to 39.
By changing -= to += it would become 10 to 19.
But should it really be 11 to 20???
>>And yesterday's question: On line 173 of fhandler_disk_file.cc
>>[strpbrk (get_win32_name (), "?*|<>|")] is there a need for the
>>two '|'? Was something else meant?
>I removed it. I don't know if there is another invalid character that
>should go there or not, though.
Is '!' invalid? It can easily be confused with '|'.
>It should be
> if (foo)
> bar = 1;
Sorry, I keep doing that.
But only once out of eleven "if"s, this time.
I am bothered that the code uses 0 as an illegal
handle value. Is that really the case?
More information about the Cygwin-patches