[PATCH] cygcheck: follow symbolic links

Corinna Vinschen corinna-cygwin@cygwin.com
Fri Feb 17 11:31:00 GMT 2006

On Feb 16 12:26, Igor Peshansky wrote:
> On Thu, 16 Feb 2006, Corinna Vinschen wrote:
> > - Most of your patch should go into path.cc so it can be reused, for
> >   instance in strace.
> Agreed -- that's why I put that TODO in there. :-)  Should I move it in
> the next iteration of the patch?

Please move it now.  I don't think it's non-trivial enough to justify
multiple iterations.

> > - Couldn't you just reuse the readlink implementation in ../cygwin/path.cc
> >   as is, to avoid having to different implementations?
> Umm, most of that code is very general purpose, and has too much extra
> stuff in it.  I basically used part of it (symlink_info::check_shortcut)
> for my implementation.  I wanted something lightweight and easy to
> understand (also, the code in path.cc doesn't check for PE headers, so I
> had to write that part anyway).

Well, what I meant isn't readlink but symlink_info::check_shortcut and
cmp_shortcut_header.  It would be helpful if the rules to identify a
symlink are identical, wouldn't it?  As for the PE headers, that's fine.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

More information about the Cygwin-patches mailing list