[PATCH] CYGWIN: Fix resolver debugging output

Corinna Vinschen corinna-cygwin@cygwin.com
Mon Feb 1 10:34:45 GMT 2021


Hi Anton,

On Jan 29 14:29, Anton Lavrentiev via Cygwin-patches wrote:
> - Use %S (instead of %s) when a wide-character output is due;

Please use %ls, %S is non-standard.

> - Use native byte order for host and add port when doing I/O with DNS server;

This puzzeled me a bit so I took another look into the original code.
Do I see this right that we have only limited IPv6 support in the
resolver code?  For instance, write_record appears to handle DNS_TYPE_A,
but not DNS_TYPE_AAAA.

CCing Pierre, hopefully he's still around.  Pierre, can you please
have a look and suggest how to go forward here?

> - Use forward way for resolv.conf's "options" processing, so listing "debug" as a
>   first option, will show all following option(s) as they are read;
> - Re-evaluate debug output flag after each "options" processing as it may chance.

Would you mind to split this into a patchset with patches for different
tasks?  ATM I'm a bit concerned about the ntoh{sl} calls, given the
noticable absence of IPv6 support...


Thanks,
Corinna


More information about the Cygwin-patches mailing list